feat: switch blob ID calculation from data offset to configurable offset #1593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Salka1988
requested review from
digorithm,
hal3e,
MujkicA and
segfault-magnet
as code owners
# Conflicts: # packages/fuels-programs/src/executable.rs
hal3e
changed the title
…uels-rs into feat/support_for_verified_abi
packages/fuels-programs/src/assembly/script_and_predicate_loader.rs
Outdated
Show resolved
Hide resolved
packages/fuels-programs/src/assembly/script_and_predicate_loader.rs
Outdated
Show resolved
Hide resolved
packages/fuels-programs/src/assembly/script_and_predicate_loader.rs
Outdated
Show resolved
Hide resolved
packages/fuels-programs/src/assembly/script_and_predicate_loader.rs
Outdated
Show resolved
Hide resolved
packages/fuels-programs/src/assembly/script_and_predicate_loader.rs
Outdated
Show resolved
Hide resolved
packages/fuels-programs/src/assembly/script_and_predicate_loader.rs
Outdated
Show resolved
Hide resolved
…er.rs Co-authored-by: Ahmed Sagdati <[email protected]>
Co-authored-by: Ahmed Sagdati <[email protected]>
Co-authored-by: Ahmed Sagdati <[email protected]>
digorithm
previously approved these changes
Feb 5, 2025
There was a problem hiding this comment.
LGTM. Great job, @Salka1988, and great suggestions, @segfault-magnet!
hal3e
requested changes
Feb 6, 2025
packages/fuels-programs/src/assembly/script_and_predicate_loader.rs
Outdated
Show resolved
Hide resolved
packages/fuels-programs/src/assembly/script_and_predicate_loader.rs
Outdated
Show resolved
Hide resolved
packages/fuels-programs/src/assembly/script_and_predicate_loader.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Ahmed Sagdati <[email protected]>
Co-authored-by: Ahmed Sagdati <[email protected]>
Co-authored-by: Ahmed Sagdati <[email protected]>
segfault-magnet
approved these changes
Feb 14, 2025
digorithm
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
In this release, we:
- Previously deployed blobs are no longer accessible due to changes in blob ID calculation. Redeployment is required.Summary
Updates blob ID calculation to use the configurable offset instead of the data offset, aligning with the updated design for scripts and predicates.
has_configurable_section_offsetfunction checks bytes 4 and 7 to distinguish binary versions. If byte 4 is 0x74 (JMPF), it considers byte 7: 0x02 means legacy, 0x04 means new, and any other value results in an error.Checklist